=============================================================================
* Forwarded by Tommi Koivula (2:221/360)
* Area : fidotest (fidotest)
* From : Tommi Koivula, 2:221/10 (23 Jan 24 08:48)
* To : Nicholas Boel
* Subj : Re: Test ============================================================================= On 23.01.2024 0:34, Nicholas Boel wrote:

On 1/22/2024 10:18 AM, Jay Harris -> Tommi Koivula wrote:
JH> On Mon, 22 Jan 2024 08:41:38 +0200
JH> "Tommi Koivula -> Jay Harris" <0@360.221.2> wrote:

TK>> On 21.01.2024 13:21, Jay Harris wrote:

JH>>>>> @MSGID: 1:229/664 65abf652
JH>>>>> @PID: JamNNTPd/Linux 1.3
JH>>>>> @CHRS: UTF-8 4

TK>> 32bit linux? Must be if it works. :)

JH> Compiled on 32bit Linux, running on 64bit.

Didn't you say you were still having issues with the FROM field not displaying properly in your newsreader?

I've been studying this. It's pretty funny that there is no problems in my OS/2 Jamnntpd. Yesterday I did more research of the code, and in nntpserv.c I commented out the line:

// strcpy(mimefrom,&mimefrom[6]);

Compiled in 64bit Ubuntu (22.04.3) with -m32, and it seems to work. For now. :)

Also it depends on the news client how it shows the "From:" in the message list. Pretty weird. :D

'Tommi

-+-
* Origin: 2a01:4f9:c011:1ec5:f1d0:2:221:10 (2:221/10) =============================================================================

---
* Origin: rbb.fidonet.fi (2:221/360)

* Originally in fidotest
* Crossposted in jamnntpd

Hi Jay.

I've been studying this. It's pretty funny that there is no problems in TK>> my OS/2 Jamnntpd. Yesterday I did more research of the code, and in
nntpserv.c I commented out the line:

// strcpy(mimefrom,&mimefrom[6]);

Compiled in 64bit Ubuntu (22.04.3) with -m32, and it seems to work. For TK>> now. :)

Also it depends on the news client how it shows the "From:" in the
message list. Pretty weird. :D

Awesome, thank you! This makes Claws Mail look a little cleaner:

https://ibb.co/LSf6tt7

And NewsTap still looks good as well.

You're welcome! I still cannot understand why some news clients show that "From: " in the msg list and some don't. Too "smart" clients maybe. :)

'Tommi

--- GoldED+/LNX 1.1.5-b20231112
* Origin: =-=---------------------------=-= (2:221/1)

23 Jan 2024 08:50, you wrote to All:

I've been studying this. It's pretty funny that there is no problems
in my OS/2 Jamnntpd. Yesterday I did more research of the code, and in nntpserv.c I commented out the line:

// strcpy(mimefrom,&mimefrom[6]);

[...]

I think that you have found the source of text corruption problems in Smapi/JamNNTPd: it may not be safe to use strcpy that way.

Carlos

--- GoldED+/W32-MSVC 1.1.5-b20180707
* Origin: cyberiada (2:341/234.1)

Carlos Navarro wrote:

I've been studying this. It's pretty funny that there is no
problems in my OS/2 Jamnntpd. Yesterday I did more research of
the code, and in nntpserv.c I commented out the line:

// strcpy(mimefrom,&mimefrom[6]);

[...]

I think that you have found the source of text corruption problems
in Smapi/JamNNTPd: it may not be safe to use strcpy that way.

Wow..!

Could it be also the reason why there are no text corruption problems in my OS/2 version of jamnntpd which is compiled with ancient gcc3 ?

Old code, old compiler...? ;)

'Tommi

--- Sylpheed 3.8.0beta1 (GTK+ 2.24.30; i686-pc-mingw32)
* Origin: 2a01:4f9:c011:1ec5:f1d0:2:221:10 (2:221/10)

25 Jan 2024 20:36, you wrote to me:

I think that you have found the source of text corruption problems
in Smapi/JamNNTPd: it may not be safe to use strcpy that way.

Wow..!

Could it be also the reason why there are no text corruption problems
in my OS/2 version of jamnntpd which is compiled with ancient gcc3 ?

I think so. I don't have those problems when compiling with MinGW for Win32, either. It seems it depends on how each compiler implements the strcpy function.

This may be a possible way to fix the corrupted From field in headers: in nntpserv.c, instead of just removing this line:

strcpy(mimefrom,&mimefrom[6]);

Replace it by:

memmove(mimefrom,mimefrom+6,strlen(mimefrom)-5);

There could also be issues with the Subject field. The next line:

strcpy(mimesubj,&mimesubj[9]);

could be changed to:

memmove(mimesubj,mimesubj+9,strlen(mimesubj)-8);

As for the corruption in the body of messages posted with newsreaders that support flowed text (like Thunderbird), I think it may be fixed by changing this:

strcpy(line,&line[1]);

to this:

memmove(line,line+1,strlen(line));

These patches are for both JamNNTPd and SmapiNNTPd.

Carlos

--- GoldED+/W32-MSVC 1.1.5-b20180707
* Origin: cyberiada (2:341/234.1)

Carlos Navarro wrote:

I think that you have found the source of text corruption
problems in Smapi/JamNNTPd: it may not be safe to use strcpy
that way.

Wow..!

Could it be also the reason why there are no text corruption
problems in my OS/2 version of jamnntpd which is compiled with
ancient gcc3 ?

I think so. I don't have those problems when compiling with MinGW
for Win32, either. It seems it depends on how each compiler
implements the strcpy function.

Yep. I have been wondering for a long time that compiling the exactly same code in different systems produce binaries that behave differently.

This may be a possible way to fix the corrupted From field in
headers: in nntpserv.c, instead of just removing this line:

strcpy(mimefrom,&mimefrom[6]);

Replace it by:

memmove(mimefrom,mimefrom+6,strlen(mimefrom)-5);

There could also be issues with the Subject field. The next line:

strcpy(mimesubj,&mimesubj[9]);

could be changed to:

memmove(mimesubj,mimesubj+9,strlen(mimesubj)-8);

As for the corruption in the body of messages posted with
newsreaders that support flowed text (like Thunderbird), I think it
may be fixed by changing this:

strcpy(line,&line[1]);

to this:

memmove(line,line+1,strlen(line));

Have to try these asap! :D

'Tommi

---
* Origin: rbb.fidonet.fi - Lake Ylo - Finland (2:221/6.0)

On 27.01.2024 21:23, Carlos Navarro wrote:

This may be a possible way to fix the corrupted From field in headers:
in nntpserv.c, instead of just removing this line:

strcpy(mimefrom,&mimefrom[6]);

Replace it by:

memmove(mimefrom,mimefrom+6,strlen(mimefrom)-5);

There could also be issues with the Subject field. The next line:

strcpy(mimesubj,&mimesubj[9]);

could be changed to:

memmove(mimesubj,mimesubj+9,strlen(mimesubj)-8);

As for the corruption in the body of messages posted with newsreaders
that support flowed text (like Thunderbird), I think it may be fixed by changing this:

strcpy(line,&line[1]);

to this:

memmove(line,line+1,strlen(line));

These patches are for both JamNNTPd and SmapiNNTPd.

Patched both, and so far so good.

If anyone wants to test, there are few open groups :

jamnntpd: mxo.fidonet.fi:119
smapinntpd: mxo.fidonet.fi:1119

'Tommi

---
* Origin: 2a01:4f9:c011:1ec5:f1d0:2:221:1 (2:221/1.0)

27 Jan 2024 20:23:35 +0100 Carlos Navarro -> Tommi Koivula:

This may be a possible way to fix the corrupted From field in headers:
in nntpserv.c, instead of just removing this line:

strcpy(mimefrom,&mimefrom[6]);

Replace it by:

memmove(mimefrom,mimefrom+6,strlen(mimefrom)-5);

There could also be issues with the Subject field. The next line:

strcpy(mimesubj,&mimesubj[9]);

could be changed to:

memmove(mimesubj,mimesubj+9,strlen(mimesubj)-8);

As for the corruption in the body of messages posted with newsreaders
that support flowed text (like Thunderbird), I think it may be fixed by changing this:

strcpy(line,&line[1]);

to this:

memmove(line,line+1,strlen(line));

These patches are for both JamNNTPd and SmapiNNTPd.

To prevent other potential problems, it is also convenient to do these other modifications in nntpserv.c:

Change every occurrence (there are 3) of:
strcpy(article,&article[1]);
to:
memmove(article,article+1,strlen(article));

Change:
strcpy(from,&from[1]);
to:
memmove(from,from+1,strlen(from));

Change:
strcpy(subject,&subject[4]);
to:
memmove(subject,subject+4,strlen(subject)+3);

And change:
strcpy(text,&text[c]);
to:
memmove(text,text+c,strlen(text)+c-1);

Carlos

--- Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32)
* Origin: cyberiada-NNTP (2:341/234.99)

On 2/4/24 8:36 PM, Carlos Navarro -> Tommi Koivula wrote:

To prevent other potential problems, it is also convenient to do these other modifications in nntpserv.c:

Change every occurrence (there are 3) of:
 strcpy(article,&article[1]);
to:
 memmove(article,article+1,strlen(article));

Change:
 strcpy(from,&from[1]);
to:
 memmove(from,from+1,strlen(from));

Change:
 strcpy(subject,&subject[4]);
to:
 memmove(subject,subject+4,strlen(subject)+3);

And change:
 strcpy(text,&text[c]);
to:
 memmove(text,text+c,strlen(text)+c-1);

Carlos

Thanks Carlos, I have these modifications in place here. I'll let you know how it goes.


Jay

--- Mozilla Thunderbird
* Origin: Northern Realms (1:229/664)

04 Feb 2024 21:36, I wrote to you:

To prevent other potential problems, it is also convenient to do these other modifications in nntpserv.c:

[...]

The last two I posted are wrong:

Change:
strcpy(subject,&subject[4]);
to:
memmove(subject,subject+4,strlen(subject)+3);

Should be:
memmove(subject,subject+4,strlen(subject)-3);

And change:
strcpy(text,&text[c]);
to:
memmove(text,text+c,strlen(text)+c-1);

Should be:
memmove(text,text+c,strlen(text)-c+1);

Sorry guys.

Carlos

--- GoldED+/W32-MSVC 1.1.5-b20180707
* Origin: cyberiada (2:341/234.1)

04 Feb 2024 16:20, you wrote to me:

Thanks Carlos, I have these modifications in place here. I'll let you know how it goes.

Sorry I made a couple typos. Check my previous message.

Carlos

--- GoldED+/W32-MSVC 1.1.5-b20180707
* Origin: cyberiada (2:341/234.1)

On 2/5/24 8:12 AM, Carlos Navarro -> Jay Harris wrote:

Sorry I made a couple typos. Check my previous message.

No worries at all, just made these corrections.


Jay

--- Mozilla Thunderbird
* Origin: Northern Realms (1:229/664)

On 05.02.2024 10:10, Carlos Navarro wrote:

Sorry guys.

Don't worry, I wasn't that fast this time. ;)

'Tommi

---
* Origin: == jamnntpd://news.fidonet.fi == (2:221/6.600)

On Mon, 5 Feb 2024 15:12:22 +0100, Carlos Navarro -> Jay Harris wrote:

Sorry I made a couple typos. Check my previous message.

Updated. Thank you. Doesn't seem like it broke anything during the time it was wrong, so we can just pretend that never happened. ;)

Regards,
Nick

... "Take my advice, I don't use it anyway."
--- Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:115.0) Gecko/20100101 Thunderb
* Origin: _thePharcyde distribution system (Wisconsin) (1:154/10)

05 Feb 2024 15:51, you wrote to me:

Updated. Thank you. Doesn't seem like it broke anything during the
time it was wrong, so we can just pretend that never happened. ;)

;-)

Carlos

--- GoldED+/W32-MSVC 1.1.5-b20180707
* Origin: cyberiada (2:341/234.1)

Hello Carlos,

On Mon, 5 Feb 2024 03:36:48 +0100, you wrote:

27 Jan 2024 20:23:35 +0100 Carlos Navarro -> Tommi Koivula:

This may be a possible way to fix the corrupted From field in headers:
in nntpserv.c, instead of just removing this line:

strcpy(mimefrom,&mimefrom[6]);

Replace it by:

memmove(mimefrom,mimefrom+6,strlen(mimefrom)-5);

There could also be issues with the Subject field. The next line:

strcpy(mimesubj,&mimesubj[9]);

could be changed to:

memmove(mimesubj,mimesubj+9,strlen(mimesubj)-8);

As for the corruption in the body of messages posted with newsreaders
that support flowed text (like Thunderbird), I think it may be fixed by
changing this:

strcpy(line,&line[1]);

to this:

memmove(line,line+1,strlen(line));

These patches are for both JamNNTPd and SmapiNNTPd.

Another reply to the same message, with another utf-8 editor. Does this one look
better to you Wilfred and Tommi?

Regards,
Nick

... Take my advice, I don't use it anyway.
--- slrn/pre1.0.4-9 (Linux)
* Origin: _thePharcyde distribution system (Wisconsin) (1:154/10)

Hello Nicholas,

On Fri, 23 Feb 2024 22:57:52 -0600, you wrote:

Hello Carlos,

On Mon, 5 Feb 2024 03:36:48 +0100, you wrote:

27 Jan 2024 20:23:35 +0100 Carlos Navarro -> Tommi Koivula:

This may be a possible way to fix the corrupted From field in
headers: in nntpserv.c, instead of just removing this line:

strcpy(mimefrom,&mimefrom[6]);

Replace it by:

memmove(mimefrom,mimefrom+6,strlen(mimefrom)-5);

There could also be issues with the Subject field. The next line:

strcpy(mimesubj,&mimesubj[9]);

could be changed to:

memmove(mimesubj,mimesubj+9,strlen(mimesubj)-8);

As for the corruption in the body of messages posted with
newsreaders that support flowed text (like Thunderbird), I think
it may be fixed by changing this:

strcpy(line,&line[1]);

to this:

memmove(line,line+1,strlen(line));

These patches are for both JamNNTPd and SmapiNNTPd.

Another reply to the same message, with another utf-8 editor. Does this one look
better to you Wilfred and Tommi?

Another reply using Claws Mail. How about this one?

Just trying to narrow down if it's Thunderbird itself, or jamnntpd.. so I know where to look.

Regards,
Nick

.. "Take my advice, I don't use it anyway."
--- Claws Mail 4.2.0 (GTK 3.24.38; x86_64-w64-mingw32)
* Origin: _thePharcyde distribution system (Wisconsin) (1:154/10)

Hi Nicholas,

On 2024-02-23 16:57:52, you wrote to Carlos Navarro:

27 Jan 2024 20:23:35 +0100 Carlos Navarro -> Tommi Koivula:

This may be a possible way to fix the corrupted From field in
headers: in nntpserv.c, instead of just removing this line:

strcpy(mimefrom,&mimefrom[6]);

Replace it by:

memmove(mimefrom,mimefrom+6,strlen(mimefrom)-5);

There could also be issues with the Subject field. The next line:

strcpy(mimesubj,&mimesubj[9]);

could be changed to:

memmove(mimesubj,mimesubj+9,strlen(mimesubj)-8);

As for the corruption in the body of messages posted with newsreaders
that support flowed text (like Thunderbird), I think it may be fixed
by changing this:

strcpy(line,&line[1]);

to this:

memmove(line,line+1,strlen(line));

These patches are for both JamNNTPd and SmapiNNTPd.

Another reply to the same message, with another utf-8 editor. Does this one
look better to you Wilfred and Tommi?

Yes, I don't see any utf-8 characters at all...

Bye, Wilfred.

--- FMail-lnx64 2.2.1.1
* Origin: FMail development HQ (2:280/464)

Hi Nicholas,

On 2024-02-23 17:01:14, you wrote to you:

Hello Carlos,

On Mon, 5 Feb 2024 03:36:48 +0100, you wrote:

27 Jan 2024 20:23:35 +0100 Carlos Navarro -> Tommi Koivula:

This may be a possible way to fix the corrupted From field in
headers: in nntpserv.c, instead of just removing this line:

strcpy(mimefrom,&mimefrom[6]);

Replace it by:

memmove(mimefrom,mimefrom+6,strlen(mimefrom)-5);

There could also be issues with the Subject field. The next line:

strcpy(mimesubj,&mimesubj[9]);

could be changed to:

memmove(mimesubj,mimesubj+9,strlen(mimesubj)-8);

As for the corruption in the body of messages posted with
newsreaders that support flowed text (like Thunderbird), I think
it may be fixed by changing this:

strcpy(line,&line[1]);

to this:

memmove(line,line+1,strlen(line));

These patches are for both JamNNTPd and SmapiNNTPd.

Another reply to the same message, with another utf-8 editor. Does
this one look better to you Wilfred and Tommi?

Another reply using Claws Mail. How about this one?

Just trying to narrow down if it's Thunderbird itself, or jamnntpd.. so I know where to look.

This looks good too!


Bye, Wilfred.

--- FMail-lnx64 2.2.1.1
* Origin: FMail development HQ (2:280/464)

Hi Nicholas.

23 Feb 24 16:57:52, you wrote to Carlos Navarro:

Another reply to the same message, with another utf-8 editor. Does this one look better to you Wilfred and Tommi?

Looks fine with slrn!

Regards,
Nick

... Take my advice, I don't use it anyway.
--- slrn/pre1.0.4-9 (Linux)

'Tommi

---
* Origin: Point One (2:221/1.1)

Hi Nicholas.

23 Feb 24 17:01:14, you wrote to you:

Another reply to the same message, with another utf-8 editor. Does
this one look better to you Wilfred and Tommi?

Another reply using Claws Mail. How about this one?

Also fine!

Just trying to narrow down if it's Thunderbird itself, or jamnntpd..
so I know where to look.

.. "Take my advice, I don't use it anyway."
--- Claws Mail 4.2.0 (GTK 3.24.38; x86_64-w64-mingw32)

'Tommi

---
* Origin: Point One (2:221/1.1)

Hello, Tommi!

Saturday February 24 2024 08:22, from Tommi Koivula -> Nicholas Boel:

Another reply to the same message, with another utf-8 editor.
Does this one look better to you Wilfred and Tommi?

Looks fine with slrn!

rtin rules them all.

Best Regards, Nil
--- GoldED+/LNX 1.1.5
* Origin: Linux 2.6.32-042stab145.3 (1:16/101)

On Sat, 24 Feb 2024 14:22:32 +0200, Tommi Koivula -> Nicholas Boel wrote:

Looks fine with slrn!

I think it will look fine with anything other than Thunderbird (or clones thereof), to be honest.

It seems Thunderbird when quoting adds a space (making it two or more) to quote levels, whereas other nntp clients don't. If you notice on some of those tests, most nntp readers bring back the quotes, no matter what level) so they were only indented one space:

NB
TK

Thunderbird does something like this:

WV
NB
TK

And at that point there are two or more spaces, so Thunderbird adds a non breaking space in there. I can't find any settings related to it, and have used some google-fu to find out that there are and has been issues regarding these non breaking spaces for quite some time.

Regards,
Nick

... "Take my advice, I don't use it anyway."
--- Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:115.0) Gecko/20100101 Thunderb
* Origin: _thePharcyde distribution system (Wisconsin) (1:154/10)